liulei/baseapi
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

- more error and warn output.

Browse Source
This commit is contained in:
gazebo
2018-07-01 10:10:50 +08:00
parent 71f774e02f
commit 1f22b95ee2
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
platformapi/mtpsapi/callback.go
View File

@@ -49,7 +49,7 @@ func (a *API) CheckCallbackValidation(request *http.Request) (callbackResponse *
for _, valueKey := range []string{"delivery_id", "mt_peisong_id", "order_id"} { for _, valueKey := range []string{"delivery_id", "mt_peisong_id", "order_id"} {
if request.FormValue(valueKey) == "" { if request.FormValue(valueKey) == "" {
baseapi.SugarLogger.Errorf("Missing mandatory param:%v", valueKey) baseapi.SugarLogger.Errorf("Missing mandatory param PostForm:%v, valueKey:%v", request.PostForm, valueKey)
return &CallbackResponse{ return &CallbackResponse{
Code: -1, Code: -1,
} }

4
platformapi/platformapi.go
View File

@@ -86,13 +86,13 @@ func AccessPlatformAPIWithRetry(client *http.Client, request *http.Request, conf
if ok && err.Timeout() && recoverableErrorRetryCount <= config.MaxRecoverableRetryCount { if ok && err.Timeout() && recoverableErrorRetryCount <= config.MaxRecoverableRetryCount {
continue continue
} else { } else {
baseapi.SugarLogger.Errorf("access api error:%v", err) baseapi.SugarLogger.Errorf("access api error:%v, request:%v", err, request)
return ErrAPIAccessFailed return ErrAPIAccessFailed
} }
} }
defer response.Body.Close() defer response.Body.Close()
if response.StatusCode != 200 { if response.StatusCode != 200 {
baseapi.SugarLogger.Errorf("HTTP code not 200, it's:%v", response.StatusCode) baseapi.SugarLogger.Errorf("HTTP code not 200, it's:%v, request:%v", response.StatusCode, request)
return ErrHTTPCodeIsNot200 return ErrHTTPCodeIsNot200
} }

10
utils/utils.go
View File

@@ -171,7 +171,7 @@ func HTTPResponse2Json(response *http.Response) (map[string]interface{}, error)
var jsonResult map[string]interface{} var jsonResult map[string]interface{}
bodyData, err := ioutil.ReadAll(response.Body) bodyData, err := ioutil.ReadAll(response.Body)
if err != nil { if err != nil {
baseapi.SugarLogger.Errorf("ioutil.ReadAll error:%v", err) baseapi.SugarLogger.Errorf("ioutil.ReadAll error:%v, response:%v", err, response)
return nil, err return nil, err
} }
@@ -186,14 +186,14 @@ func HTTPBody2Values(data []byte, needDecode bool) (url.Values, error) {
if needDecode { if needDecode {
bodyStr1, err := url.QueryUnescape(bodyStr) bodyStr1, err := url.QueryUnescape(bodyStr)
if err != nil { if err != nil {
baseapi.SugarLogger.Errorf("QueryUnescape error:%v", err) baseapi.SugarLogger.Errorf("QueryUnescape error:%v, bodyStr:%v", err, bodyStr)
return nil, err return nil, err
} }
bodyStr = bodyStr1 bodyStr = bodyStr1
} }
result, err := url.ParseQuery(bodyStr) result, err := url.ParseQuery(bodyStr)
if err != nil { if err != nil {
baseapi.SugarLogger.Errorf("ParseQuery error:%v", err) baseapi.SugarLogger.Errorf("ParseQuery error:%v, bodyStr:%v", err, bodyStr)
return nil, err return nil, err
} }
return result, nil return result, nil
@@ -202,7 +202,7 @@ func HTTPBody2Values(data []byte, needDecode bool) (url.Values, error) {
func MustInterface2Int64(data interface{}) int64 { func MustInterface2Int64(data interface{}) int64 {
dataNumber, ok := data.(json.Number) dataNumber, ok := data.(json.Number)
if !ok { if !ok {
panic(fmt.Sprintf("error when convert:%v", data)) panic(fmt.Sprintf("error when cast:%v to int64", data))
} }
retVal, err := dataNumber.Int64() retVal, err := dataNumber.Int64()
if err != nil { if err != nil {
@@ -238,7 +238,7 @@ func MergeMaps(firstMap map[string]interface{}, otherMaps ...map[string]interfac
func CallFuncLogError(funcToCall func() error, msg string) error { func CallFuncLogError(funcToCall func() error, msg string) error {
err := funcToCall() err := funcToCall()
if err != nil { if err != nil {
baseapi.SugarLogger.Warnf("%s, error:%v", err.Error()) baseapi.SugarLogger.Warnf("%s, error:%v", msg, err.Error())
} }
return err return err
} }