- refactor, remove unnecessary log.

platformapi/platformapi.go

@@ -56,11 +56,9 @@ const (
 
 // common api access error
 var (
-	ErrAPIAccessFailed             = errors.New("access API failed")
-	ErrHTTPCodeIsNot200            = errors.New("HTTP code is not 200")
-	ErrRecoverableErrReachMaxRetry = errors.New("recoverable error reach max retry count")
-	ErrLimitExceedReachMaxRetry    = errors.New("limit exceed reach max retry count")
-	ErrResponseDataFormatWrong     = errors.New("the data of response has wrong format")
+	ErrAPIAccessFailed         = errors.New("access API failed")
+	ErrHTTPCodeIsNot200        = errors.New("HTTP code is not 200")
+	ErrResponseDataFormatWrong = errors.New("the data of response has wrong format")
 )
 
 // common callback response
@@ -80,22 +78,21 @@ func AccessPlatformAPIWithRetry(client *http.Client, request *http.Request, conf
 	for {
 		response, err := client.Do(request)
 		if err != nil {
-			baseapi.SugarLogger.Debugf("client.Get return err:%v", err)
+			baseapi.SugarLogger.Debugf("AccessPlatformAPIWithRetry client.Get return err:%v", err)
 			err, ok := err.(net.Error)
 			recoverableErrorRetryCount++
 			if ok && err.Timeout() && recoverableErrorRetryCount <= config.MaxRecoverableRetryCount {
 				continue
 			} else {
-				baseapi.SugarLogger.Errorf("access api error:%v, request:%v", err, request)
+				baseapi.SugarLogger.Errorf("AccessPlatformAPIWithRetry access api request:%v, error:%v", request, err)
 				return ErrAPIAccessFailed
 			}
 		}
 		defer response.Body.Close()
 		if response.StatusCode != 200 {
-			baseapi.SugarLogger.Errorf("HTTP code not 200, it's:%v, request:%v", response.StatusCode, request)
+			baseapi.SugarLogger.Errorf("AccessPlatformAPIWithRetry HTTP code is:%d, request:%v", response.StatusCode, request)
 			return ErrHTTPCodeIsNot200
 		}
-
 		errLevel, err := handleResponse(response)
 		if err == nil {
 			return nil
@@ -104,16 +101,14 @@ func AccessPlatformAPIWithRetry(client *http.Client, request *http.Request, conf
 			if exceedLimitRetryCount <= config.MaxExceedLimitRetryCount {
 				time.Sleep(config.SleepSecondWhenExceedLimit)
 				continue
-			} else {
-				return ErrLimitExceedReachMaxRetry
 			}
 		} else if errLevel == ErrLevelRecoverableErr {
 			recoverableErrorRetryCount++
 			if recoverableErrorRetryCount <= config.MaxRecoverableRetryCount {
 				continue
 			}
-			return err
 		}
+		baseapi.SugarLogger.Infof("AccessPlatformAPIWithRetry failed, error:%v", err)
 		return err
 	}
 }