diff --git a/business/elm/controller/order.go b/business/elm/controller/order.go index e1fec9214..6f052c629 100644 --- a/business/elm/controller/order.go +++ b/business/elm/controller/order.go @@ -23,7 +23,6 @@ func (o *OrderController) OrderMessage(msg *elmapi.CallbackMsg) *elmapi.Callback var innerMsg map[string]interface{} err := utils.UnmarshalUseNumber([]byte(msg.Message), &innerMsg) if err != nil { - globals.SugarLogger.Warnf("OrderMessage unmarshal %v error:%v", msg, err) return errResponseDataError } if msg.Type == elmapi.MsgTypeOrderValid { @@ -49,12 +48,10 @@ func (o *OrderController) NewOrder(msg *elmapi.CallbackMsg, orderId string) *elm if created || rec.Type != msg.Type { result, err := globals2.ElmAPI.GetOrder(orderId) if err != nil { - globals.SugarLogger.Warnf("call GetOrder error:%v", err) return errResponseCallELMAPIError } err = globals2.FreshFoodAPI.NewELMOrder(result) if err != nil { - globals.SugarLogger.Warnf("internal error:%v", err) return errResponseInternal } } else { @@ -77,7 +74,6 @@ func (o *OrderController) OrderStatusChanged(msg *elmapi.CallbackMsg, orderId st if rec.Type != msg.Type { err = globals2.FreshFoodAPI.ELMOrderStatus(orderId, msg.Type, utils.GetCurTimestamp()) if err != nil { - globals.SugarLogger.Warnf("internal error:%v", err) return errResponseInternal } else { rec.Type = msg.Type diff --git a/business/jd/controller/order.go b/business/jd/controller/order.go index 491b28df5..739303dfa 100644 --- a/business/jd/controller/order.go +++ b/business/jd/controller/order.go @@ -136,10 +136,7 @@ func (c *OrderController) OrderStatus(order *jdapi.CallbackOrderMsg) *jdapi.Call } func (c *OrderController) OrderDeliveryStatus(jdOrderDeliveryStatusMsg *jdapi.CallbackDeliveryStatusMsg) *jdapi.CallbackResponse { - err := globals2.FreshFoodAPI.JDOrderDeliveryStatus(jdOrderDeliveryStatusMsg) - - if err != nil { - globals.SugarLogger.Errorf("Error when calling JDOrderDeliveryStatus, error:%v", err) + if err := globals2.FreshFoodAPI.JDOrderDeliveryStatus(jdOrderDeliveryStatusMsg); err != nil { return &jdapi.CallbackResponse{jdapi.ResponseCodeAccessFailed, err.Error(), ""} } @@ -154,9 +151,7 @@ func acceptOrder(order *jdapi.CallbackOrderMsg) { func newOrder(order *jdapi.CallbackOrderMsg) error { result, err := globals2.Jdapi.LegacyQuerySingleOrder(order.BillID) acceptOrder(order) - if err != nil { - globals.SugarLogger.Errorf("error when query jd order:%s, error:%v", order.BillID, err) - } else { + if err == nil { rec := &models.Jdorder{ Id: order.ID, } @@ -224,9 +219,8 @@ func normalOrderStatus(order *jdapi.CallbackOrderMsg) error { rec.OrderStatus = utils.Str2Int(order.StatusID) rec.OrderStatusTime = order.Timestamp - err = globals2.FreshFoodAPI.JDOrderStatus(rec) - if err != nil { - globals.SugarLogger.Warnf("access freshfood failed, error:%v", err) + + if err = globals2.FreshFoodAPI.JDOrderStatus(rec); err != nil { return err }