- RefreshWeixinToken and RefreshElmToken firs time run must completed before main workflow going.

legacy/tasks/configrefresh.go

@@ -1,6 +1,7 @@
 package tasks
 
 import (
+	"fmt"
 	"time"
 
 	"git.rosy.net.cn/jx-callback/globals/api"
@@ -29,60 +30,70 @@ type ElmTokenForCompatible struct {
 	Success          bool   `json:"success"`
 }
 
-func RefreshConfig(configKey string, expiresTime time.Duration, configGetter func() string, configSetter func(value string)) {
-	go func() {
-		sleepGap := expiresTime / 10
-		needRefreshGap := expiresTime * 8 / 10
-		if sleepGap > maxRefreshGap {
-			sleepGap = maxRefreshGap
+func RefreshConfig(configKey string, expiresTime time.Duration, configGetter func() string, configSetter func(value string)) error {
+	sleepGap := expiresTime / 10
+	needRefreshGap := expiresTime * 8 / 10
+	if sleepGap > maxRefreshGap {
+		sleepGap = maxRefreshGap
+	}
+	refreshFunc := func() error {
+		curConfig := &models.Config{
+			Thirdparty: configKey,
 		}
-		for {
-			curConfig := &models.Config{
-				Thirdparty: configKey,
-			}
-
-			db := orm.NewOrm()
-			// 0: don't refresh, 1 update, 2 insert
-			handleType := 0
-			if err := db.Read(curConfig, "Thirdparty"); err != nil {
-				if err != orm.ErrNoRows {
-					globals.SugarLogger.Errorf("db error:%v, curConfig:%v", err, curConfig)
-				} else {
-					curConfig.Token = configGetter()
-					handleType = 2
-				}
+		db := orm.NewOrm()
+		// 0: don't refresh, 1 update, 2 insert
+		handleType := 0
+		if err := db.Read(curConfig, "Thirdparty"); err != nil {
+			if err != orm.ErrNoRows {
+				globals.SugarLogger.Errorf("db error:%v, curConfig:%v", err, curConfig)
+				return err
 			} else {
-				latestTimeStr := utils.Time2Str(time.Now().Add(-needRefreshGap))
-				if curConfig.Date <= latestTimeStr {
-					curConfig.Token = configGetter()
-					handleType = 1
-				}
+				curConfig.Token = configGetter()
+				handleType = 2
 			}
-
-			if handleType != 0 {
-				globals.SugarLogger.Debugf("refresh %s, value:%s", configKey, curConfig.Token)
-				curConfig.Date = utils.GetCurTimeStr()
-				var num int64
-				var err error
-
-				if handleType == 1 {
-					num, err = db.Update(curConfig, "Token", "Date")
-				} else {
-					num, err = db.Insert(curConfig)
-				}
-				if err != nil || num == 0 {
-					globals.SugarLogger.Errorf("db error:%v, num:%d, curConfig:%v", err, num, curConfig)
-				} else {
-					configSetter(curConfig.Token)
+		} else {
+			latestTimeStr := utils.Time2Str(time.Now().Add(-needRefreshGap))
+			if curConfig.Date <= latestTimeStr {
+				if curConfig.Token = configGetter(); curConfig.Token == "" {
+					return fmt.Errorf("can not get token for %s", configKey)
 				}
+				handleType = 1
 			}
-			time.Sleep(sleepGap)
 		}
-	}()
+		if handleType != 0 {
+			globals.SugarLogger.Debugf("refresh %s, value:%s", configKey, curConfig.Token)
+			curConfig.Date = utils.GetCurTimeStr()
+			var num int64
+			var err error
+
+			if handleType == 1 {
+				num, err = db.Update(curConfig, "Token", "Date")
+			} else {
+				num, err = db.Insert(curConfig)
+			}
+			if err != nil || num == 0 {
+				globals.SugarLogger.Errorf("db error:%v, num:%d, curConfig:%v", err, num, curConfig)
+				return err
+			} else {
+				configSetter(curConfig.Token)
+			}
+		}
+		return nil
+	}
+	err := refreshFunc() // 这样写的目的是强制第一次调用时要刷新一次
+	if err == nil {
+		go func() {
+			for {
+				time.Sleep(sleepGap)
+				refreshFunc()
+			}
+		}()
+	}
+	return err
 }
 
-func RefreshWeixinToken() {
-	RefreshConfig("wechat", weixinTokenExpires, func() string {
+func RefreshWeixinToken() error {
+	return RefreshConfig("wechat", weixinTokenExpires, func() string {
 		if tokenInfo, err := api.WeixinAPI.RefreshToken(); err == nil {
 			return tokenInfo.AccessToken
 		}
@@ -93,8 +104,8 @@ func RefreshWeixinToken() {
 	})
 }
 
-func RefreshElmToken() {
-	RefreshConfig("eleme", elmTokenExpires, func() string {
+func RefreshElmToken() error {
+	return RefreshConfig("eleme", elmTokenExpires, func() string {
 		if tokenInfo, err := api.ElmAPI.RefreshTokenIndividual(); err == nil {
 			tokenInfo2 := &ElmTokenForCompatible{
 				Error:            "",