diff --git a/business/jxcallback/orderman/order.go b/business/jxcallback/orderman/order.go
index c7bbc6802..ba0da084f 100644
--- a/business/jxcallback/orderman/order.go
+++ b/business/jxcallback/orderman/order.go
@@ -394,7 +394,7 @@ func updateSingleOrderEarningPrice(order *model.GoodsOrder, db *dao.DaoDB) {
 		skuIDMap[v.SkuID] = 1
 	}
 	if len(skuIDMap) > 0 {
-		actStoreSkuList, err := dao.GetEffectiveActStoreSkuInfo(db, 0, []int{order.VendorID}, 0, []int{jxStoreID}, jxutils.IntMap2List(skuIDMap), order.OrderCreatedAt, order.OrderCreatedAt)
+		actStoreSkuList, err := dao.GetEffectiveActStoreSkuInfo(db, 0, []int{order.VendorID}, model.ActTypeAll, []int{jxStoreID}, jxutils.IntMap2List(skuIDMap), order.OrderCreatedAt, order.OrderCreatedAt)
 		if err != nil {
 			globals.SugarLogger.Errorf("updateOrderSkuOtherInfo can not get sku promotion info for error:%v", err)
 		}
diff --git a/business/jxcallback/orderman/order_afs.go b/business/jxcallback/orderman/order_afs.go
index 72b56873a..776050f21 100644
--- a/business/jxcallback/orderman/order_afs.go
+++ b/business/jxcallback/orderman/order_afs.go
@@ -273,7 +273,7 @@ func (c *OrderManager) updateAfsOrderSkuOtherInfo(db *dao.DaoDB, order *model.Af
 		var actStoreSkuMap *jxutils.ActStoreSkuMap
 		if len(skuIDMap) > 0 {
 			if order2, err2 := c.LoadOrder(order.VendorOrderID, order.VendorID); err2 == nil {
-				actStoreSkuList, err := dao.GetEffectiveActStoreSkuInfo(db, 0, []int{order.VendorID}, 0, []int{jxStoreID}, jxutils.IntMap2List(skuIDMap), order2.OrderCreatedAt, order2.OrderCreatedAt)
+				actStoreSkuList, err := dao.GetEffectiveActStoreSkuInfo(db, 0, []int{order.VendorID}, model.ActTypeAll, []int{jxStoreID}, jxutils.IntMap2List(skuIDMap), order2.OrderCreatedAt, order2.OrderCreatedAt)
 				if err != nil {
 					globals.SugarLogger.Errorf("updateAfsOrderSkuOtherInfo can not get sku promotion info for error:%v", err)
 					return err
diff --git a/business/jxstore/misc/store_score.go b/business/jxstore/misc/store_score.go
index 0454e96d4..cf3752bf4 100644
--- a/business/jxstore/misc/store_score.go
+++ b/business/jxstore/misc/store_score.go
@@ -396,7 +396,7 @@ func ScorePromotionSku(storeInfo *cms.StoreExt) {
 	db := dao.GetDB()
 	beginTime := time.Now()
 	endTime := time.Now()
-	actStoreSkuList, err := dao.GetEffectiveActStoreSkuInfo(db, -1, nil, 0, []int{storeID}, nil, beginTime, endTime)
+	actStoreSkuList, err := dao.GetEffectiveActStoreSkuInfo(db, -1, nil, model.ActTypeAll, []int{storeID}, nil, beginTime, endTime)
 	finalScore := 0
 	if err == nil && len(actStoreSkuList) > 0 {
 		actStoreSkuMap := make(map[int]int)
diff --git a/business/model/act.go b/business/model/act.go
index b4bfeee86..bc792e542 100644
--- a/business/model/act.go
+++ b/business/model/act.go
@@ -7,6 +7,7 @@ import (
 )
 
 const (
+	ActTypeAll       = -1
 	ActSkuFake       = 0 // 假活动，只用于存储活动结算信息
 	ActSkuDirectDown = 3 // 兼容之前的
 	ActSkuSecKill    = 4 // 兼容之前的
diff --git a/business/model/dao/act.go b/business/model/dao/act.go
index c5b6f626b..0137b566d 100644
--- a/business/model/dao/act.go
+++ b/business/model/dao/act.go
@@ -409,7 +409,7 @@ func GetEffectiveActStoreSkuInfo(db *DaoDB, actID int, vendorIDs []int, actType
 		sql = " AND t1.act_type = ?"
 		sqlParams = append(sqlParams, actID)
 	}
-	if actType > 0 {
+	if actType != model.ActTypeAll {
 		sql = " AND t1.type = ?"
 		sqlParams = append(sqlParams, actType)
 	}
diff --git a/business/model/dao/act_test.go b/business/model/dao/act_test.go
index 687fc0298..be48eee2a 100644
--- a/business/model/dao/act_test.go
+++ b/business/model/dao/act_test.go
@@ -5,6 +5,7 @@ import (
 	"time"
 
 	"git.rosy.net.cn/baseapi/utils"
+	"git.rosy.net.cn/jx-callback/business/model"
 )
 
 func TestGetEffectiveActStoreSkuInfo(t *testing.T) {
@@ -27,7 +28,7 @@ func TestGetEffectiveActStoreSkuInfo(t *testing.T) {
 			ToTime:      utils.Str2Time("2019-08-06 12:34:56"),
 		},
 	} {
-		result, err := GetEffectiveActStoreSkuInfo(GetDB(), v.ActID, v.VendorIDs, 0, v.StoreIDs, v.SkuIDs, v.FromTime, v.ToTime)
+		result, err := GetEffectiveActStoreSkuInfo(GetDB(), v.ActID, v.VendorIDs, model.ActTypeAll, v.StoreIDs, v.SkuIDs, v.FromTime, v.ToTime)
 		if err != nil {
 			t.Fatal(err)
 		}
diff --git a/business/model/dao/store_sku.go b/business/model/dao/store_sku.go
index 3b1461f44..d35415100 100644
--- a/business/model/dao/store_sku.go
+++ b/business/model/dao/store_sku.go
@@ -1136,7 +1136,7 @@ func UpdateActPrice4StoreSkuNameNew(db *DaoDB, storeIDs, skuIDs []int, skuNamesI
 	if actVendorID >= 0 {
 		vendorIDs = []int{actVendorID}
 	}
-	actStoreSkuList, err := GetEffectiveActStoreSkuInfo(db, 0, vendorIDs, 0, storeIDs, skuIDs, time.Now(), time.Now())
+	actStoreSkuList, err := GetEffectiveActStoreSkuInfo(db, 0, vendorIDs, model.ActTypeAll, storeIDs, skuIDs, time.Now(), time.Now())
 	if err != nil {
 		globals.SugarLogger.Errorf("updateActPrice4StoreSkuNameNew can not get sku promotion info for error:%v", err)
 		return err