- refactor http.Get

business/jxstore/initdata/initdata.go

@@ -9,6 +9,8 @@ import (
 	"net/http"
 	"strings"
 
+	"git.rosy.net.cn/baseapi/platformapi"
+
 	"git.rosy.net.cn/baseapi/platformapi/autonavi"
 	"git.rosy.net.cn/baseapi/platformapi/jdapi"
 	"git.rosy.net.cn/baseapi/utils"
@@ -153,11 +155,15 @@ func InitSkuName(ctx *jxcontext.Context, isForce, isAsync, isContinueWhenError b
 				response, err := http.Get(skuName.Img)
 				if err == nil {
 					defer response.Body.Close()
-					data, err2 := ioutil.ReadAll(response.Body)
+					if response.StatusCode == http.StatusOK {
-					if err = err2; err == nil {
+						data, err2 := ioutil.ReadAll(response.Body)
-						skuName.ImgHashCode = fmt.Sprintf("%X", md5.Sum(data))
+						if err = err2; err == nil {
-						db := dao.GetDB()
+							skuName.ImgHashCode = fmt.Sprintf("%X", md5.Sum(data))
-						_, err = dao.UpdateEntity(db, skuName, "ImgHashCode")
+							db := dao.GetDB()
+							_, err = dao.UpdateEntity(db, skuName, "ImgHashCode")
+						}
+					} else {
+						err = platformapi.ErrHTTPCodeIsNot200
 					}
 				}
 			}

business/jxutils/jxutils_cms.go

@@ -270,9 +270,7 @@ func (s SkuList) Swap(i, j int) {
 func DownloadFileByURL(fileURL string) (bodyData []byte, fileMD5 string, err error) {
 	response, err := http.Get(fileURL)
 	if err == nil {
-		defer func() {
+		defer response.Body.Close()
-			response.Body.Close()
-		}()
 		if response.StatusCode == http.StatusOK {
 			if bodyData, err = ioutil.ReadAll(response.Body); err == nil {
 				fileMD5 = fmt.Sprintf("%X", md5.Sum(bodyData))